fix(api): add seed npcs.json to unblock main CI and market tests (#83) - #124
fix(api): add seed npcs.json to unblock main CI and market tests (#83)#124angelTomo9 wants to merge 2 commits into
Conversation
Code Review ✅ Approved 1 resolved / 1 findingsAdds the missing npcs.json seed fixture without a UTF-8 BOM to unblock CI and market integration tests. Resolved issues regarding JSON.parse compatibility. ✅ 1 resolved✅ Bug: UTF-8 BOM makes npcs.json fail JSON.parse, defeating the fix
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 7 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
|
Cierro esta porque el archivo que agrega ya está en El diagnóstico era correcto: La otra mitad era Lo medí levantando el job de API en local con el mismo Por eso se mergeó la #109, que traía los dos archivos con los datos completos del No hace falta que hagas nada. Si tenés algo más sobre la issue que no sea el |
Closes #83
Summary of Changes
Adds
api/src/jsons/npcs.jsonseed fixture to preventENOENT: no such file or directory, open '.../api/src/jsons/npcs.json'failures in CI and local test execution ofsrc/tests/market.integration.test.ts.Features & Deliverables
game_npcsdatabase seeding andlistNpcSoldItemIds().market.integration.test.tscan resolve NPC merchant listings to test auction house cancellations and fee reimbursements.